Skip to content

CNDB-15262: add needsReconciliation flag to fix IntersectFilteringQueryTest #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

CNDB-15262: add needsReconciliation flag to fix IntersectFilteringQueryTest #1975

merged 1 commit into from
Sep 3, 2025

Conversation

@driftx
Copy link

@driftx driftx commented Sep 2, 2025

What is the issue

IntersectFilteringQueryTest.shouldFailOnFilteringQuery and shouldWarnOnFilteringQuery are failing

What does this PR fix and why was it fixed

needsReconciliation needs to be passed in order for a quorum level query to be used

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx
Copy link
Author

driftx commented Sep 2, 2025

Also fixes a checkstyle error I ran into.

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-1975 approved by Butler

Approved by Butler
See build details here

@driftx driftx requested a review from djatnieks September 2, 2025 20:11
@driftx driftx merged commit d4a096f into main-5.0 Sep 3, 2025
576 of 590 checks passed
@driftx driftx deleted the CNDB-15262 branch September 3, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djatnieks djatnieks djatnieks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driftx @cassci-bot @djatnieks